search

readium / r2-testapp-swift

BSD 3-Clause "New" or "Revised" License
147 stars 38 forks source link

Improve the README #326

Closed ettore closed 4 years ago

ettore commented 4 years ago

Tested on a fresh checkout of the repo.

mickael-menu commented 4 years ago

@ettore Can you check that you're using the latest version of develop for all the Readium libraries?

You're reverting deprecated APIs: https://github.com/readium/r2-testapp-swift/commit/806432e72b3d81e7d034d9a9134d9e8f28674043#diff-e235701991a2d31bf5e74cc64281fe44

If you remove your changes in the code, I'm fine merging your fixes in the README.

ettore commented 4 years ago

I see, I'll revert these shortly. Sorry for the confusion. It wasn't clear to me that I had to manually fix the cartfile dependencies to build develop. Is that an assumption here, and if so can I take a stab at making that more explicit in the readme? Or should I update the cartfile instead?

mickael-menu commented 4 years ago

@ettore Sure, any improvement to the README is most welcome 👍

For the Cartfile, @aferditamuriqi is managing the packages and release, so you'll have to see with her.