search

readium / readium-cfi-js

BSD 3-Clause "New" or "Revised" License
44 stars 45 forks source link

export-var is broken in build script #53

Closed danielweck closed 8 years ago

danielweck commented 8 years ago

See failure in TravisCI log: https://travis-ci.org/readium/readium-js-viewer/jobs/155993925

See PegJS change log regarding multiple module format support: https://github.com/pegjs/pegjs/blob/master/README.md

''' --format — format of the generated parser: amd, commonjs, globals, umd (default: commonjs) '''

TODO: try the new format option in the task 'build:scripts:peg' (npm run pegjs --export-var window.EPUBcfiParser cfi_parser.pegjs gen/cfi_parser_gen.js) https://github.com/readium/readium-cfi-js/blob/develop/package.cson

danielweck commented 8 years ago

This should be fixed by https://github.com/readium/readium-cfi-js/commit/2454bd1ca075517ad3feeff3716abc5a1e8695bd (waiting for TravisCI build to complete ... https://travis-ci.org/readium/readium-js-viewer/builds/156215435 )

danielweck commented 8 years ago

TravisCI passes https://travis-ci.org/readium/readium-cfi-js/builds/156214950 https://travis-ci.org/readium/readium-js-viewer/builds/156215435

See EPUB CFI parser window global object (new method for injecting the object during AMD module bootstrapping): https://github.com/readium/readium-shared-js/commit/59763db4a9b8ef5a9d080f17d7e0001e754979e5

...I need to check the unit tests locally on my machine because Travis only runs a particular RequireJS bundling type...

danielweck commented 8 years ago

Tests all pass fine with npm run http and the various RequireJS AMD module bundling tests:

index_NO-RequireJS_TESTS.html index_NO-RequireJS.html index_RequireJS_multiple-bundles_TESTS.html index_RequireJS_multiple-bundles.html index_RequireJS_no-optimize_TESTS.html index_RequireJS_no-optimize.html index_RequireJS_single-bundle_TESTS.html index_RequireJS_single-bundle.html

danielweck commented 8 years ago

TODO: must fix the master branch! (cherry-pick)