danielweck
commented
1 year ago I tested الحرب_والسلم_(الكتاب_الأول).epub with Thorium. The page renders fine, I think:
...but, Thorium injects additional stylesheets immediately after the ReadiumCSS "after" layer (which itself comes after publishers styles, which itself comes after ReadiumCSS "before" layer). The injected CSS is the product of incremental findings following weird edge-case bug reports (there is still a known problem with some HTML pages that don't extend the full height, so it is not "perfect" yet). The CSS bugs are super tricky to reproduce, sometimes impossible from the Web Inspector (must author the CSS at source and do a hard page reload, can't dynamically change properties in the style debugger).
For what it's worth, here is the current stack of CSS overrides in Thorium:
/*
https://github.com/readium/readium-css/issues/117
no new stacking context, otherwise massive performance degradation with CSS Columns in large HTML documents
(web inspector profiler shows long paint times, some layout recalc triggers too)
*/
:root {
-webkit-perspective: none !important;
perspective: none !important;
}
:root[style].r2-css-paginated:not(.r2-fixed-layout),
:root.r2-css-paginated:not(.r2-fixed-layout) {
overflow: visible !important;
}
:root[style].r2-css-paginated:not(.r2-fixed-layout) > body,
:root.r2-css-paginated:not(.r2-fixed-layout) > body {
overflow-x: hidden !important;
overflow-y: visible !important;
}
:root[style].r2-fixed-layout,
:root.r2-fixed-layout {
overflow: hidden !important;
}
:root[style].r2-fixed-layout > body,
:root.r2-fixed-layout > body {
overflow: hidden !important;
margin: 0 !important;
}
:root.r2-css-paginated > body,
:root:not(.r2-css-paginated) > body,
:root.r2-fixed-layout > body,
:root:not(.r2-fixed-layout) > body,
:root[style].r2-css-paginated > body,
:root[style]:not(.r2-css-paginated) > body,
:root[style].r2-fixed-layout > body,
:root[style]:not(.r2-fixed-layout) > body {
position: relative !important;
}
:root[style]:not(.r2-css-paginated):not(.r2-fixed-layout),
:root:not(.r2-css-paginated):not(.r2-fixed-layout) {
height: 100vh !important;
}
:root[style]:not(.r2-fixed-layout) > body,
:root:not(.r2-fixed-layout) > body {
min-height: inherit;
}
:root[style]:not(.r2-css-paginated):not(.r2-fixed-layout) > body,
:root:not(.r2-css-paginated):not(.r2-fixed-layout) > body {
height: inherit;
}
mickael-menu
stevenzeck
Originally posted by @stevenzeck in https://github.com/readium/kotlin-toolkit/issues/292#issuecomment-1301535645
Original Bug Report by A-Fawzyy
What happened?
The attached epub's chapter shows in a single page, where it should show over several pages.
https://user-images.githubusercontent.com/38096011/199537331-a167f47a-0f17-4765-8b07-a173600f3432.mp4
Expected behavior
Only a part of the chapter should show, and the rest of the chapter should be displayed after navigating to the next page.
Actual behavior
The chapter is rendered in a single page.
How to reproduce?
الحربوالسلم(الكتاب_الأول).epub.zip The ebup download url: https://downloads.hindawi.org/books/26307461.epub
Environment
Development environment
Testing device
Additional context