Upgrade AccessibleDfa to 1.7

readium / readium-css

🌈 A set of reference stylesheets for EPUB Reading Systems, starting with Readium Mobile

https://readium.org/readium-css/

BSD 3-Clause "New" or "Revised" License

89 stars 20 forks source link

Upgrade AccessibleDfa to 1.7 #123

Closed mickael-menu closed 3 months ago

mickael-menu commented 1 year ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, other)

Upgrade the embedded AccessibleDfa font files to fix an issue with some glyphs always displayed with a black color. I took this opportunity to add the italic and bold variants as well.

What is the current behaviour? (You can also link to an open issue here)

When switching on the night theme, the commas are disappearing (they stay black).

What is the new behaviour?

AccessibleDfa 1.7 fixes the issue.

danielweck commented 1 year ago

fixes https://github.com/readium/readium-css/issues/56 ?

mickael-menu commented 3 months ago

Does anyone have the permissions to merge this? cc @aferditamuriqi @danielweck

aferditamuriqi commented 3 months ago

Does anyone have the permissions to merge this? cc @aferditamuriqi @danielweck

i don't , sorry

aferditamuriqi commented 3 months ago

@mickael-menu looks like only Jiminy has write access, but we can ask @llemeurfr to add someone to that team https://github.com/orgs/readium/teams/readium-css-committers

danielweck commented 3 months ago

let's go! (I checked the PR contents but didn't actually test it)

mickael-menu commented 3 months ago

Thanks Daniel