[x] I’m making this pull request against the develop branch
[x] I’ve updated from the develop branch before proposing this pull request
[x] I’ve tested the changes for bug fixes and/or features
[x] I’ve documented new code
What kind of change does this PR introduce? (Bug fix, feature, docs update, other)
This PR implement Thorium changes that can be useful to all consumers of ReadiumCSS.
Specifically:
it resolves #136
it resolves #140
it fixes #94
it fixes #128
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
It should only introduce fixes and new user settings. That said the situation may be slightly different for Thorium and other apps having handled #94 and #128, given the fixes and features are already implemented in another way.
Otherwise, it’s 2 extra user settings to implement:
letter-spacing in CJK
hiding ruby annotation using a new flag --USER__no-ruby: readium-noRuby-on (part of settings requiring the advanced flag).
Other information:
I guess @danielweck would be the best one to check/review this PR, considering his changes are ported into ReadiumCSS as a whole.
But any feedback welcome, especially on hiding ruby annotation cos’ naming things is hard, and perhaps we don’t want to tie it to advanced settings, it should just be its own thing with no other flag required.
Please check if the PR fulfills these requirements:
(Add x between brackets to check.)
What kind of change does this PR introduce? (Bug fix, feature, docs update, other)
This PR implement Thorium changes that can be useful to all consumers of ReadiumCSS.
Specifically:
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
It should only introduce fixes and new user settings. That said the situation may be slightly different for Thorium and other apps having handled #94 and #128, given the fixes and features are already implemented in another way.
Otherwise, it’s 2 extra user settings to implement:
--USER__no-ruby: readium-noRuby-on(part of settings requiring the advanced flag).Other information:
I guess @danielweck would be the best one to check/review this PR, considering his changes are ported into ReadiumCSS as a whole.
But any feedback welcome, especially on hiding ruby annotation cos’ naming things is hard, and perhaps we don’t want to tie it to advanced settings, it should just be its own thing with no other flag required.