readium / readium-css

🌈 A set of reference stylesheets for EPUB Reading Systems, starting with Readium Mobile
https://readium.org/readium-css/
BSD 3-Clause "New" or "Revised" License
90 stars 20 forks source link

i18n samples markup leaves much to be desired #33

Open JayPanoz opened 6 years ago

JayPanoz commented 6 years ago

To sum things up those samples were automatically created from Wikipedia pages, and the markup is quite unsatisfactory – to say the least. It can occasionally create issues in vertical writing mode as some divs will overlap.

Although they’re good enough for our current tests, which are quick i18n checks (font, default, metadata, etc.), it could be useful to improve markup in the future so that we can extend tests to more complex stuff (including advanced user settings, etc.).

I won’t be able to manage that for the time being (got the alpha version to release and monitor) so any PR would be greatly appreciated. If you’re willing to help, do not hesitate to contact me if you have questions. Please be aware you must sign and send the Readium ICLA before doing the PR though.