search

readium / readium-css

🌈 A set of reference stylesheets for EPUB Reading Systems, starting with Readium Mobile
https://readium.org/readium-css/
BSD 3-Clause "New" or "Revised" License
90 stars 20 forks source link

Font face case discrepancies, Accessible DFA vs. Dfa (and DfA ;) #35

Closed danielweck closed 6 years ago

danielweck commented 6 years ago

AccessibleDFA should be AccessibleDfa:

https://github.com/readium/readium-css/blob/edfdc2a9c213023d4094b54dd3b57ae53d4af5bf/css/dist/ReadiumCSS-after.css#L676

https://github.com/readium/readium-css/blob/edfdc2a9c213023d4094b54dd3b57ae53d4af5bf/css/dist/ReadiumCSS-before.css#L310

(the file itself is AccessibleDfA, but that's alright ;)

JayPanoz commented 6 years ago

Ah thanks, good catch. It’s been corrected on the alpha branch. 👍

danielweck commented 6 years ago

This is fixed in master, right?

JayPanoz commented 6 years ago

Yes. I can confirm it should be fixed in the master branch now.

But maybe you want to align on the file itself i.e. AccessibleDfA?

danielweck commented 6 years ago

I'm in favour of consistency, so if you want you may indeed use AccessibleDfA everywhere (i.e. filename, font-face declaration + font-family CSS property) :)

JayPanoz commented 6 years ago

It’s now fixed in the develop branch.

JayPanoz commented 6 years ago

Is now on master, closing this issue.