search

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
555 stars 185 forks source link

Chrome Extension Windows 7: Author inserted No Spreads, User selection comes up as spreads #191

Open Kathybluefire opened 10 years ago

Kathybluefire commented 10 years ago

I have a reflowable document which has NO SPREADS in the rendition:spreads property. The book works fine, does not present spreads even with the browser pulled all the way out (which would ususally force spreads) but when I go to the user menu to change layout options the spreads selection under Display Format is selected. image I think this behavior is confusing to a user. Can we grey out the spreads choice if we are not going to allow the user to override the author in this case? By having spreads selected and singles presented we are providing a bad user experience.

The file is called 02_Reflow_NoSpreads and located at: https://bluefireproductions.box.com/s/91bxhl28sl75miwx6uzy

Kathybluefire commented 10 years ago

Additionally, Auto should be grayed out for this file. Auto would present spreads in a window with an aspect ratio wider than high.

rkwright commented 10 years ago

I would agree that the whole spreads row should be grayed out if spreads="none". And the one-up should be selected (but not selectable), just to show the user that's what they get - no matter what they want. However, we really need to review this area post-GM.

danielweck commented 10 years ago

User settings always take precedence over authored metadata. This is a design decision that was made from the onset, and we used Boris' rendition-layout grid/matrix as the authoritative document to check that we implement the algorithm correctly. On that basis, I would suggest closing this issue as "invalid". Let me know if I have missed something :) PS: "auto" in the settings dialog is not the same thing as "auto" in EPUB3 metadata.