search

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
553 stars 186 forks source link

No alt text on log images in about dialog #556

Closed becka11y closed 7 years ago

becka11y commented 8 years ago

There is no alt text on the partner images in the about dialog box. The screen reader (tested in VO) will read the name of the image, partner_logos, which makes some sense but the actual partners should be listed - HTML5, idpf, pub

This issue is a Bug

Expected Behavior

The screen reader should announce the 3 partners when the image is encountered: HTML5, idpf, pub

Observed behavior

The screen reader announces the image name.

Steps to reproduce

  1. Load a screen reader. I tested with VoiceOver (VO) in Safari
  2. load readium cloud reader
  3. tab to and open the About dialog. Make sure focus is in the about dialog (tab or follow VO instructions)
  4. navigate through the items in the about dialog until you reach the image. Note that the screen reader just speaks the image name, partnter_logos.png. In VO you navigate to each item by pressing the VO keys (control+option) and the left or right arrow keys.

    Product

Readium Chrome Extension 2.23.0 Browser and version: Chrome Version 51.0.2704.106 (64-bit)

becka11y commented 8 years ago

We could elect to ignore those logos for screen reader users and just add empty alt text rather than indicating the logos. This would require no translation of the alt text to other languages. Although, I don't believe we would need to translate the names "HTML5, I d p f, e PUB" anyways. Someone just need to make the call as to whether or not those logos are just decorative. I would argue they are not.

derekriemer commented 8 years ago

If you do choose to ignore them, putting role=presentation or aria-hidden on them is preferable.

Thanks.

On 7/25/2016 11:10 AM, Becky Gibson wrote:

We could elect to ignore those logos for screen reader users and just add empty alt text rather than indicating the logos. This would require no translation of the alt text to other languages. Although, I don't believe we would need to translate the names "HTML5, I d p f, e PUB" anyways. Someone just need to make the call as to whether or not those logos are just decorative. I would argue they are not.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/readium/readium-js-viewer/issues/556#issuecomment-235017772, or mute the thread https://github.com/notifications/unsubscribe-auth/AFGivb7RLxpyeC0dNC4pGP_BMbkCEDxkks5qZO4CgaJpZM4JUU0a.

Derek Riemer

Websites: Honors portfolio http://derekriemer.com Awesome little hand built weather app! http://django.derekriemer.com/weather/

email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu Phone: (303) 906-2194