search

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
554 stars 186 forks source link

Full Screen Button with embedded lite reader #562

Closed sage-IT closed 7 years ago

sage-IT commented 8 years ago

Hey, I know this issue was here before but I cant seem to solve it. With an embedded iframe even if I set the allowfullscreen attribute I still cant get full screen mode. When the link to the epub is placed in the address bar i am able to set full screen etc. I thought it might have been settings on my website but I tested a youtube video with and without the allowfullscreen and this worked fine.

danielweck commented 8 years ago

Thanks for posting the issue again. Let's investigate this further.

danielweck commented 8 years ago

Usages of 'screenfull' in https://github.com/readium/readium-js-viewer/blob/develop/src/js/EpubReader.js#L652 Source: https://github.com/sindresorhus/screenfull.js

'iframe@allowFullScreen="true"' ? Seems to be known bugs about iframe support: https://github.com/bdougherty/BigScreen/blob/master/src/bigscreen.js

http://stackoverflow.com/questions/19440234/how-to-make-a-whole-website-run-under-fullscreen-with-screenfull-js

sage-IT commented 8 years ago

screenfull did the trick. Thanks for the help

danielweck commented 8 years ago

what do you mean? can you please explain how you fixed this?

sage-IT commented 8 years ago

I guess I mis-worded my answer. As an alternate solution to not having the full screen button on the iframe I used the fullscreen.js script. By creating a simple button I was able to put the iframe element into full screen ZAYD BHYAT I.T SUPPORT OFFICER

  SAGE MEDIA GROUP PTY LTD 8/4 QUEEN STREET BENTLEY WA 6102 AUSTRALIA F: +61 8 9458 1136   http://www.sagemedia.com.au/

SAGE MEDIA GROUP PTY LTD 8/4 QUEEN STREET BENTLEY WA 6102 AUSTRALIA F: +61 8 9458 1136

http://www.sagemedia.com.au/    http://nationalresourcesreview.com.au/

This email and any files transmitted with it are confidential to the intended recipient and may be privileged. If you have received this email inadvertently or you are not the  intended recipient, you may not disseminate, distribute, copy or in any way rely on it. Further, you should notify the sender immediately and delete the email from your  computer. Whilst we have taken precautions to alert us to the presence of viruses,  we cannot guarantee that this email and any files transmitted with it are free from viruses.   http://www.buildaustralia.com.au/

This email and any files transmitted with it are confidential to the intended recipient and may be privileged. If you have received this email inadvertently or you are not the intended recipient, you may not disseminate, distribute, copy or in any way rely on it. Further, you should notify the sender immediately and delete the email from your computer. Whilst we have taken precautions to alert us to the presence of viruses, we cannot guarantee that this email and any files transmitted with it are free from viruses.

http://www.buildaustralia.com.au/

On 30 Aug 2016, at 1:49 pm, Daniel Weck notifications@github.com wrote:

what do you mean? can you please explain how you fixed this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/readium/readium-js-viewer/issues/562#issuecomment-243339581, or mute the thread https://github.com/notifications/unsubscribe-auth/AUHlNgGjYrTrZxcI_6L5s3fgY8Kc0JQXks5qk8RjgaJpZM4Jssuj.

danielweck commented 8 years ago

okay, so it looks like the fullscreen API requires targeting the iframe element rather then the hosted document element, when Readium is embedded inside an iframe.

sage-IT commented 8 years ago

I haven’t tried targeting the hosted document or any element within the iFrame, like an image etc. ZAYD BHYAT I.T SUPPORT OFFICER

  SAGE MEDIA GROUP PTY LTD 8/4 QUEEN STREET BENTLEY WA 6102 AUSTRALIA F: +61 8 9458 1136   http://www.sagemedia.com.au/

SAGE MEDIA GROUP PTY LTD 8/4 QUEEN STREET BENTLEY WA 6102 AUSTRALIA F: +61 8 9458 1136

http://www.sagemedia.com.au/    http://nationalresourcesreview.com.au/

This email and any files transmitted with it are confidential to the intended recipient and may be privileged. If you have received this email inadvertently or you are not the  intended recipient, you may not disseminate, distribute, copy or in any way rely on it. Further, you should notify the sender immediately and delete the email from your  computer. Whilst we have taken precautions to alert us to the presence of viruses,  we cannot guarantee that this email and any files transmitted with it are free from viruses.   http://www.buildaustralia.com.au/

This email and any files transmitted with it are confidential to the intended recipient and may be privileged. If you have received this email inadvertently or you are not the intended recipient, you may not disseminate, distribute, copy or in any way rely on it. Further, you should notify the sender immediately and delete the email from your computer. Whilst we have taken precautions to alert us to the presence of viruses, we cannot guarantee that this email and any files transmitted with it are free from viruses.

http://www.buildaustralia.com.au/

On 30 Aug 2016, at 2:59 pm, Daniel Weck notifications@github.com wrote:

okay, so it looks like the fullscreen API requires targeting the iframe element rather then the hosted document element, when Readium is embedded inside an iframe.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/readium/readium-js-viewer/issues/562#issuecomment-243350513, or mute the thread https://github.com/notifications/unsubscribe-auth/AUHlNgV19gNFOCt5tlbxkHCbVHJIF-qWks5qk9TegaJpZM4Jssuj.