readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
551 stars 186 forks source link

CloudReader allows choosing the "Add..." button even if it hangs the app #598

Open rkwright opened 7 years ago

rkwright commented 7 years ago

This issue is a Bug

Related issue(s) and/or pull request(s)

None

Expected Behaviour

You shouldn't be able to select an option that doesn't work and hangs the app!

Observed behaviour

Open the CloudReader, select the "+" icon.

Steps to reproduce

  1. Open the CloudReaader
  2. Select the "+" icon
  3. CR opens a dialog and you can choose a book.
  4. App then hangs since adding new books isn't supported.

Test file(s)

None needed. Any EPUB will do.

Product

Additional information

N/A

danielweck commented 7 years ago

Duplicate? https://github.com/readium/readium-js-viewer/issues/82

rkwright commented 7 years ago

In a sense, yes, though 82 is presented more a need to allow people to add books to the CloudReader library. Let's leave both open for the moment.