search

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
551 stars 186 forks source link

GitHub + SauceLabs authentication access tokens should be Readium, not individual developers #603

Open danielweck opened 7 years ago

danielweck commented 7 years ago

Related issue: https://github.com/readium/readium-js-viewer/issues/565

danielweck commented 7 years ago

GitHub (fork updater, invoked during npm run prepare): https://github.com/readium/readium-cfi-js/blob/master/readium-build-tools/gitHubForksUpdater.js#L18

danielweck commented 7 years ago

SauceLabs: https://github.com/readium/readium-cfi-js/blob/master/.travis.yml#L9 https://github.com/readium/readium-js-viewer/blob/master/.travis.yml#L98

danielweck commented 7 years ago

TODO check what this secure field is for: https://github.com/readium/readium-js-viewer/blob/master/.travis.yml#L102 (IIRC this is for GitHub integration in TravisCI)