Fullscreen button not updated when entering fullscreen mode

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library

BSD 3-Clause "New" or "Revised" License

550 stars 186 forks source link

Fullscreen button not updated when entering fullscreen mode #625

Closed HGuillemet closed 6 years ago

HGuillemet commented 7 years ago

I see in EpubReader.js that the fullscreen button is supposed to change when entering fullscreenmode (icon and tooltip). But this is not working.

This issue is a Bug

Product

Readium cloud reader app
Tested on Firefox and Safari

danielweck commented 6 years ago

I am not able to reproduce this bug (OSX Safari and Chrome). Tested with: https://readium.firebaseapp.com/?epub=epub_content%2Faccessible_epub_3&goto=%7B%22idref%22%3A%22id-id2611884%22%2C%22elementCfi%22%3A%22%2F4%2F2%5Bintroduction%5D%2F2%2F1%3A0%22%7D Can you please provide some details? (platform, versions, etc.)

HGuillemet commented 6 years ago

When I click on the link you provide, then on the fullscreen icon, I do enter fullscreen mode, but the icon still looks the same and the tooltip still reads "Enter fullscreen". This happens on Firefox 52.3.0/Linux and Safari 11.0/MacOS

danielweck commented 6 years ago

oh, my bad, I misread your bug description, sorry.

danielweck commented 6 years ago

Fixed via PR: https://github.com/readium/readium-js-viewer/pull/654