search

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
550 stars 186 forks source link

boolean settings (such as popup footnote ON / OFF preference) are ignored at app reload #626

Closed danielweck closed 7 years ago

danielweck commented 7 years ago

Culprit: !readerSettings[prop] should be typeof readerSettings[prop] == "undefined" in EpubReader.js and ReaderSettingsDialog.js.

danielweck commented 7 years ago

Fixed in https://github.com/readium/readium-js-viewer/commit/51b4e618aaa8c37fb78b77c3dd1ea925ce619b10