search

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
550 stars 186 forks source link

Use Readium specific namespace for require.config if available #633

Closed jccr closed 7 years ago

jccr commented 7 years ago

Related to https://github.com/readium/readium-cfi-js/pull/65 If that's merged this is needed too.

danielweck commented 7 years ago

I see, thanks!

danielweck commented 7 years ago

Is this needed in all the ReadiumJS repos?

jccr commented 7 years ago

After talking with Daniel Weck about this, we found that there would be breaking changes like these not just in the Readium side but potentially in other places external to Readium, for example anyone who's configured Readium with require.config in their own code.

I'm closing this due to this and other consequences of using RequireJS with a specific namespace.