search

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
550 stars 186 forks source link

Hypothes.is annotations: right nav button overlaps contents when offset-ed #650

Closed danielweck closed 6 years ago

danielweck commented 6 years ago

...as a result, links or other kinds of interactive elements are obscured by the nav button, which normally has its own reserved space.

https://github.com/readium/readium-shared-js/blob/develop/plugins/hypothesis/main.js#L18-L23

https://github.com/readium/readium-js-viewer/blob/c66f5250ba4b4feed779834e759760365597327a/src/js/EpubReader.js#L1231-L1240

@JCCR I am working on a fix.

danielweck commented 6 years ago

PR1/2: https://github.com/readium/readium-js-viewer/pull/651

danielweck commented 6 years ago

PR2/2: https://github.com/readium/readium-shared-js/pull/413

danielweck commented 6 years ago

Fixed via the aforementioned Pull Requests.