Hypothes.is annotations: action menu callout (icon buttons) are enabled in TOC view! (dialogs UI as well)

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library

BSD 3-Clause "New" or "Revised" License

550 stars 186 forks source link

Hypothes.is annotations: action menu callout (icon buttons) are enabled in TOC view! (dialogs UI as well) #653

Open danielweck opened 6 years ago

danielweck commented 6 years ago

Reproduce here: https://readium.firebaseapp.com/?epub=epub_content%2Faccessible_epub_3&goto=%7B%22idref%22%3A%22id-id2611884%22%2C%22elementCfi%22%3A%22%2F4%2F2%5Bintroduction%5D%2F2%2F1%3A0%22%7D (open TOC, and see how it is possible to create annotations in the hierarchical list of headings)

So, is it possible to scope the annotator engine?

danielweck commented 6 years ago

For some reason, annotations in Bootstrap popup modal dialogs are not enabled (e.g. the Readium "about box", or the settings dialog). Can a similar implicit exclusion technique be used for the TOC panel?

danielweck commented 6 years ago

The modal dialogs are actually affected as well: the Hypothesis callout menu (when selecting text) appears beneath the dialogs due to CSS z-index !

danielweck commented 6 years ago