readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
550 stars 186 forks source link

Nav problem with page-progression-direction=rtl(cloud reader 2.28.0-alpha) #661

Open toshiakikoike opened 6 years ago

toshiakikoike commented 6 years ago

This issue is a Bug

Expected Behaviour

From Navigation, link to valid fragment identifier.

Observed behaviour

Instead, Readium does not link to valid fragment identifier, when EPUB's page-progression-direction="rtl"

Steps to reproduce

  1. First, open the test file by readium-js-viewer : cloud-reader
  2. Then open navigation
  3. Click, Chapter2, Chapter3, then jump far backward from valid fragment.

Test file(s)

https://github.com/toshiakikoike/epub_file/blob/master/holms-hound-of-the-baskervilles.epub https://github.com/toshiakikoike/epub_file/tree/master/holms-hound-of-the-baskervilles

Product

Chrome extension(from Chrome Web Store) has no problem.

Additional information

For example, "book_0003.xhtml" has 3 fragment identifiers; <h3 class="mystyle_heading-2" id="toc-002">Chapter 1</h3> -- this fragment is in the top of this html file. <h3 class="mystyle_heading-2" id="toc-003">Chapter 2</h3> -- this fragment is in the middle of this html file. <h3 class="mystyle_heading-2" id="toc-004">Chapter 3</h3> -- this fragment is in the middle of this html file.

In toc.xhtm; <li><a href="text/book_0003.xhtml#toc-002">Chapter 1</a></li> <li><a href="text/book_0003.xhtml#toc-003">Chapter 2</a></li> <li><a href="text/book_0003.xhtml#toc-004">Chapter 3</a></li>

danielweck commented 6 years ago

Thank you for reporting this RTL vertical-writing-mode bug! Test link: https://readium.firebaseapp.com/?epub=https%3A%2F%2Frawgit.com%2Ftoshiakikoike%2Fepub_file%2Fmaster%2Fholms-hound-of-the-baskervilles

danielweck commented 6 years ago

cc @JCCR