search

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
550 stars 186 forks source link

Cant get the newly release 0.28 #674

Closed mahag closed 6 years ago

mahag commented 6 years ago

Hello Am trying to follow the steps as usually to get the latest readium-js viewer 0.28.But am getting an error on npm run prepare:all I have node version 8.0.0 and Os Windows 7 64 bit

These are the errors untitled1 untitled2 untitled3

danielweck commented 6 years ago

Could you please use another terminal than MS-DOS, such as GitBash or GitShell which come with the official GiHub and Git tools for Windows. Sorry for the inconvenience, let us know if this helps.

mahag commented 6 years ago

I have downloaded the git bash from here https://git-for-windows.github.io/. npm run prepare:all worked But now it is stopping at npm run build. These are the errors 2

danielweck commented 6 years ago

Thank you for the update. Could you please now try from the develop branch. A bug was recently fixed to resolve NPM dependencies issues. Many thanks!

tddpirate commented 6 years ago

Could you please tag a version with the NPM dependency issues fix?

danielweck commented 6 years ago

The bugfix for the NPM dependencies is multi-faceted and has not been retro-fitted into the master branch as a hotfix cherry-pick. Instead, it will be incorporated into the master branch along with a history of other non-breaking improvements, at the next release point. Meanwhile, I would recommend using the source tree from the head of the develop branch, which ; as of today ; is revision 2a41a144ad75cb33058c0684a817aa2fe332f907 https://github.com/readium/readium-js-viewer/commit/2a41a144ad75cb33058c0684a817aa2fe332f907 (this commit hash will pull-in the correct chain of submodule dependencies too)