search

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
550 stars 186 forks source link

Hypothes.is annotations: similar text is being anchored in both content and UI #679

Open jccr opened 6 years ago

jccr commented 6 years ago

This issue is a Bug

Related issue(s) and/or pull request(s)

Loosely related to: #653

Expected Behaviour

Text being annotated in the book content should stay in the book content and not appear as an anchor in the UI or vice versa.

Observed behaviour

Annotations with similar text are being anchored (highlighted) by the hypothesis client across all frame levels, which means the UI top level frame and the book content frames.

Steps to reproduce

  1. Open https://readium.firebaseapp.com/?epub=epub_content%2Faccessible_epub_3&goto=epubcfi(/6/20!/4/2%5Bbuilding_a_better_epub%5D/2/1:0)
  2. Open the sidebar and login to hypothes.is
  3. Switch to a private group or be prepared to make a private annotation
  4. Highlight the chapter header's "Building a Better EPUB" phrase.
  5. Open the ToC. Notice that the same phrase is also annotated there as a duplicate.

Test file(s)

https://readium.firebaseapp.com/?epub=epub_content%2Faccessible_epub_3&goto=epubcfi(/6/20!/4/2%5Bbuilding_a_better_epub%5D/2/1:0)

Product

Additional information

This sounds like a bug with H itself and not with this project. Let's keep a tab of it here.

danielweck commented 6 years ago

Related: https://github.com/readium/readium-js-viewer/issues/653