readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
550 stars 186 forks source link

NPM vs. YARN: the former currently breaks shared-js build, missing URI.js dependency in node_modules / package-lock.json #682

Closed danielweck closed 6 years ago

danielweck commented 6 years ago

See: https://groups.google.com/forum/#!topic/readium-dev/Q39SRBLFoI0

danielweck commented 6 years ago

CC @JCCR

danielweck commented 6 years ago

Explanation: Yarn was somewhat behaving differently than NPM when fetching default / implicit branches of GitHub dependencies. Now all references are explicit in ReadiumJS, and the build works again. Problem closed.

danielweck commented 6 years ago

Also useful to analyse the tree of dependencies and update the package.json ^a.b.c versions accordingly: https://david-dm.org/readium/readium-js-viewer https://david-dm.org/readium/readium-js https://david-dm.org/readium/readium-shared-js https://david-dm.org/readium/readium-cif-js