readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
550 stars 186 forks source link

update japanese message #690

Open toshiakikoike opened 6 years ago

toshiakikoike commented 6 years ago

General Instructions

This pull request is a Work In Progress

Additional information

I add localized strings reference to en-US/message.json. There are some strings remaind English.

danielweck commented 6 years ago

Hello, thank you! Could you please change the PR target from master to develop? (use the "edit" button)

danielweck commented 6 years ago

I already posted a couple of comments (see above, inlined in this discussion thread).

However, there are a number of non-translated strings (still in English). Does this mean this PR is not ready yet? Or do you need help to clarify the meaning / usage in the User Interface?