readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
550 stars 186 forks source link

CSS is being injected into the CloudReader causing background to be brown #706

Closed rkwright closed 6 years ago

rkwright commented 6 years ago

This issue is a Bug

Related issue(s) and/or pull request(s)

None

Expected Behaviour

Background in the CloudReader should be white (unless some other specified) and text should be black, not brown...

Observed behaviour

Instead each page on the CloudReader site has a brown background and dark brown text background and white text. But note that this appears ONLY when the CloudReader is deployed locally using jekyll. It doesn't seem to occur in the Firebase site, but at present (25 July) the Firebase site can't be updated properly (see issue 333) so it might occur there as well.

Steps to reproduce

  1. Clone readium-js-viewer from the develop branch (0.31-alpha)
  2. Then build normally (npm run prepare:all)
  3. Start the build (npm run http)
  4. Open any or all of the files. Observe that each file has a brown background - even the files on the remote (OPDS) sites

Test file(s)

None needed - any file on the site will do

Product

Additional information

Tested on MacOS Sierra 10.12.6 on a MacBookPro with Chrome 67

danielweck commented 6 years ago

I am unable to reproduce this bug locally or remotely. Ric, could you please try the following links and report back:

Firebase: https://readium.firebaseapp.com

Surge: https://readium.surge.sh/?epubs=https%3A%2F%2Freadium.firebaseapp.com%2Fepub_content%2Fepub_library.opds

rkwright commented 6 years ago

Appears to have been a stale repo (or similar). Closing until and if I can reproduce it.