search

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
550 stars 186 forks source link

Annotation delete alert disappearing immediately. #717

Closed coler-j closed 5 years ago

coler-j commented 5 years ago

This issue is a Bug

Expected Behaviour

Annotation alert stays on window until clicked.

Observed behaviour

When an annotation browser alert appears it automatically disappears.

Steps to reproduce

  1. Click delete on an existing annotation
  2. Behaviour occurs

Product

Choose one of the following (and delete the others)

Additional information

See video for behaviour: http://recordit.co/H8N8V7E8Xk I have localized this issue to being triggered here:

  1. Delete button on Annotation is clicked
  2. readium.reader.on(ReadiumSDK.Events.PAGINATION_CHANGED, function (pageChangeData) function is triggered
  3. savePlace(); is called from page change function
  4. history.replaceState is called which seems to cause the trouble behaviour.
danielweck commented 5 years ago

@JCCR have you seen this before?

rkwright commented 5 years ago

@coler-j Thanks for the report. Unfortunately, the ReadiumJS codebase that you are using is part of "Readium-1" which has recently been moved to "maintenance status". We will fix crashes or data loss which occur in the master or develop. But the annotation support has always been an experiment (most folks implemented their own support - and didn't push it back).
We would strongly encourage you to take a look at "Readium-2" which is the main focus. However, the "Desktop" version (which will support MacOS, Windows and Linux is currently in alpha so if Windows support is critical you may need to stick with your implementation in the short term.

coler-j commented 5 years ago

@rkwright that is very interesting. I would have thought I was using the most recent version after having followed the documentation for installation from master branch (within the past 30 days). How is a new developer to the library supposed to known the difference between Readium 1 vs Readium 2, and how do I know what version I am using? This is the first time I am hearing about this (I have also read through many of the open and closed issues over the past few weeks).

If this is the case, someone with the knowledge of the roadmap should seriously maintain the github repo and add this information directing developers to the repo that should be used.

It looks like whoever maintains the readium website should also update that too in order to make "getting started" / "getting involved" much clearer.