Issues with <a> tags getting removed in Readium Js viewer reader.

575755 commented 4 years ago

Hi, We are facing issues with highlight feature when the migrated data coming up.

When we are doing a highlight in same content and same word the Xpath given by the old reader(not readium) and new reader is different.
After debugging we come to know that few elements are not coming in the new reader(Readium Js viewer)
In the actual physical file there were tags available in the .html file and these tags are missing in the content rendered in our new reader. (We have checked the elements in the developer console)

Please find the examples of old reader and new reader Xpath with the decoded details for same text below:

Old Reader:

L2h0bWwvYm9keS9wWzJdL2E6OnBhcmVudE5vZGUsL2h0bWwvYm9keS9wWzJdL2E6OnBhcmVudE5vZGUsMTgsMjc=

/html/body/p[2]/a::parentNode,/html/body/p[2]/a::parentNode,18,27

New Reader: L2h0bWwvYm9keS9wWzNdOjpwYXJlbnROb2RlLC9odG1sL2JvZHkvcFszXTo6cGFyZW50Tm9kZSwxOCwyNw==

/html/body/p[3]::parentNode,/html/body/p[3]::parentNode,18,27

575755 commented 4 years ago

Hi, Please take this issue as a priority .

danielweck commented 4 years ago

When a HTML tag is present in the raw source, but missing in the computed DOM, this may be a sign that there is a mismatch between XHTML and HTML (e.g. self-closing tags). Just a thought.

575755 commented 4 years ago

Hi Daniel,

We have only (.html) file for the physical content .In the below we have added two screenshots one is from browser perspective physical file and another one is from our code-base physical file .So we have compared both the file and tried to make changes in our code-base physical file as you suggested to check with the self-closing tags in the comment .

In that file one tag is given as self-closed tag. So we tried like by changing pre-closed tag as normal .. tag . after changing we are getting like this:

After changing all things also still same issue we are facing. So, We are not getting whether it is adding a duplicate tag or removing tag in the DOM structure in this particular issue. Because only for this tag Xpath is coming different.

575755 commented 3 years ago

Hi Daniel,

We have attached the screenshot of wherein we have "data-src" and "src" .Now we are loading an .xhtml file through data-src(attached screenshot) .However, the rendered content(screenshot attached) is not matching with our data-src content. So help us how can we get the rendered content same as the data-src content as it is critical for our release.</p> <img width="899" alt="data-src content1" src="https://user-images.githubusercontent.com/68894357/96262540-8ba67e00-0fdf-11eb-8045-0837bfa67760.PNG"> <img width="557" alt="data-src content2" src="https://user-images.githubusercontent.com/68894357/96262547-8ea16e80-0fdf-11eb-950f-d63e56404678.PNG"> <img width="387" alt="rendered content" src="https://user-images.githubusercontent.com/68894357/96262549-8f3a0500-0fdf-11eb-85eb-e1c1d1f03ea8.PNG"> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/danielweck"><img src="https://avatars.githubusercontent.com/u/625201?v=4" />danielweck</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>perhaps this explanation helps? <a href="https://github.com/readium/readium-js-viewer/issues/747#issuecomment-714428559">https://github.com/readium/readium-js-viewer/issues/747#issuecomment-714428559</a></p> <p>Another thing comes to mind (which could explain the closing tag issue): HTML vs. XHTML file extension triggers different parsing behaviour in some web browsers, when the HTTP header content-type is not available.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

readium / readium-js-viewer

Issues with <a> tags getting removed in Readium Js viewer reader. #742