search

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
549 stars 186 forks source link

Broken NPM package dependencies due to unstable / non-fixed references to GitHub repositories (branch HEADs) #757

Closed danielweck closed 2 years ago

danielweck commented 2 years ago

readium-cfi-js is not affected:

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package.json#L44-L46

==>

https://github.com/readium/readium-cfi-js/blob/0.31.0/package.json#L48-L68

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package-lock.json#L3069-L3071

"readium-cfi-js": {
      "version": "github:readium/readium-cfi-js#ad82c14c7c9d846e073a8010471fdd1f261c76a4",
      "from": "github:readium/readium-cfi-js#v0.31.0-alpha",
danielweck commented 2 years ago

readium-shared-js is affected:

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package.json#L44-L77

danielweck commented 2 years ago

readium-js is affected:

https://github.com/readium/readium-js/blob/b2c65bf3dd3b47ec716d328479a3c8af51fde0d2/package.json#L47-L59

danielweck commented 2 years ago

readium-js-viewer is affected:

https://github.com/readium/readium-js-viewer/blob/1653d5f813e2dea8744546a946a02d7e4fd8562c/package.json#L48-L83

danielweck commented 2 years ago

Plan of action: restore sanity in master and develop branch. First step: the package-lock.json files dictate the actual versions that are supported by each repository at this point in time.

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package-lock.json#L3069-L3071

"readium-cfi-js": {
      "version": "github:readium/readium-cfi-js#ad82c14c7c9d846e073a8010471fdd1f261c76a4",
      "from": "github:readium/readium-cfi-js#v0.31.0-alpha",

https://github.com/readium/readium-js/blob/b2c65bf3dd3b47ec716d328479a3c8af51fde0d2/package-lock.json#L315-L317

"http-server": {
      "version": "github:danielweck/http-server#70902a29413aa922c1b3484a1c4a04ed58894dde",
      "from": "github:danielweck/http-server#master",

https://github.com/readium/readium-js/blob/b2c65bf3dd3b47ec716d328479a3c8af51fde0d2/package-lock.json#L755-L757

"zip-js": {
      "version": "github:danielweck/zip.js#f71eda6df5a85aad2b96c8718c33b97e13b684ee",
      "from": "github:danielweck/zip.js#master",

https://github.com/readium/readium-js-viewer/blob/1653d5f813e2dea8744546a946a02d7e4fd8562c/package-lock.json#L1062-L1064

"http-server": {
      "version": "github:danielweck/http-server#70902a29413aa922c1b3484a1c4a04ed58894dde",
      "from": "github:danielweck/http-server#master",

https://github.com/readium/readium-js-viewer/blob/1653d5f813e2dea8744546a946a02d7e4fd8562c/package-lock.json#L1190-L1192

"jath": {
      "version": "github:danielweck/jath#ed637b98dda03f763346b044b33f17f7bf6ab64c",
      "from": "github:danielweck/jath#master",

https://github.com/readium/readium-js-viewer/blob/1653d5f813e2dea8744546a946a02d7e4fd8562c/package-lock.json#L1273-L1275

"keymaster": {
      "version": "github:danielweck/keymaster#c154e408b0ff18f122e8e84e38ab320e20eb8102",
      "from": "github:danielweck/keymaster#master",

https://github.com/readium/readium-js-viewer/blob/1653d5f813e2dea8744546a946a02d7e4fd8562c/package-lock.json#L1317-L1319

"mathjax-single-file": {
      "version": "github:danielweck/MathJax-single-file#e5b8b188f59595af8cb0cef4bfd855ec91b18571",
      "from": "github:danielweck/MathJax-single-file#master",
danielweck commented 2 years ago

Other third parties:

https://github.com/readium/readium-js-viewer/blob/1653d5f813e2dea8744546a946a02d7e4fd8562c/package-lock.json#L202-L204

    "bootstrap-accessibility-plugin": {
      "version": "github:paypal/bootstrap-accessibility-plugin#fbbf870eafc1ee5d4547fabbeea71778ddbe2166",
      "from": "github:paypal/bootstrap-accessibility-plugin#main",

https://github.com/readium/readium-js-viewer/blob/1653d5f813e2dea8744546a946a02d7e4fd8562c/package-lock.json#L935-L937

"grunt-selenium-webdriver": {
      "version": "github:levexis/grunt-selenium-webdriver#e9f63af80c8e6738b00812370c6f1ba13c5dc817",
      "from": "github:levexis/grunt-selenium-webdriver#master",

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package-lock.json#L52-L54

"amdclean": {
      "version": "github:JCCR/amdclean#e4ffc3d8a634110ec7ce7e2474e859c021afe5fc",
      "from": "github:JCCR/amdclean#master",

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package-lock.json#L969-L971

"domReady": {
      "version": "github:requirejs/domReady#d85bdc38a6df868ead52ab3e80715aaf60e68765",
      "from": "github:requirejs/domReady#master",

https://github.com/readium/readium-shared-js/blob/15412a0b8b9c98d060885fa98584a8205dce6a8d/package-lock.json#L2123-L2125

"jquery-sizes": {
      "version": "github:JCCR/jquery-sizes#d26d2510d069f84a64052c443a06b8534c5e9d0e",
      "from": "github:JCCR/jquery-sizes#master",
danielweck commented 2 years ago

Fixed in the develop branches of all affected repositories. Automatic CI deploy: https://readium.surge.sh https://readium.firebaseapp.com

danielweck commented 2 years ago

v0.32.0 release tag on master branch:

https://github.com/readium/readium-js-viewer/tree/v0.32.0

https://github.com/readium/readium-js/tree/v0.32.0

https://github.com/readium/readium-shared-js/tree/v0.32.0

Readium CFI JS is unchanged:

https://github.com/readium/readium-cfi-js/tree/0.31.0

danielweck commented 2 years ago

Released: https://github.com/readium/readium-js-viewer/releases/tag/v0.32.0