search

readium / readium-js-viewer

👁 ReadiumJS viewer: default web app for Readium.js library
BSD 3-Clause "New" or "Revised" License
553 stars 186 forks source link

Migrate from (legacy) Packaged App to new Chrome App (once storage wipe bug is fixed) #80

Closed danielweck closed 9 years ago

danielweck commented 10 years ago

Old: https://developer.chrome.com/extensions/apps

New: https://developer.chrome.com/apps/about_apps

Storage wipe problem:

https://code.google.com/p/chromium/issues/detail?id=302577

danielweck commented 9 years ago

This was fixed some time ago: https://github.com/readium/readium-js-viewer/commit/4ccf4db4e28c157912b9bfe35166d65a2f0a3deb https://github.com/readium/readium-js-viewer/commit/506032e04dee4778f1291e30890c7f0814fd2da2

danielweck commented 6 years ago

And for the record, changelog from early 2014 (different codebase file structure back then, prior to a massive build system refactoring, which makes it hard to track down using the Git commit history from the head of the master or develop branches): https://github.com/readium/readium-js-viewer/commit/c7f05ba25caa4077f7ca67f23de2273a2e9483f9#diff-738fce7b295981b1ef38efe3c072922c => introduction of code to migrate publications from the WebSQL database to HTML5 FileSystem storage (from old Extension to legacy Chrome Packaged App?)

So pretty much a year later (early 2015), the transition from legacy Chrome Packaged App to Chrome Platform App occurs, with Ryan fixing a data migration bug in the Chrome app platform (v42 release), and finally the Readium app is upgraded too (and in the process, users loose the address bar, built-in CTRL-F in-page search, tabs, etc.)

So, the suggestion to rollback from the current Readium Chrome App to an Extension (in order to work around Google's planned deprecation) not only raises questions in terms of UX, but also with respect to technical feasibility and development costs (debatable benefits for end-users and developer community, given the transition of efforts to Readium2, or the ReadiumJS 1-2 hybrid aka "Readium NG").