search

readium / readium-lcp-client

This repository is for the Readium Licenced Content Protection (LCP) client side implementation work.
BSD 3-Clause "New" or "Revised" License
17 stars 12 forks source link

Broken build on latest MacOS and XCode #47

Closed danielweck closed 6 years ago

danielweck commented 6 years ago

MacOS: Mojave 10.14 XCode: 10.1 (10B61)

Notably in platform/apple/src/LCPStatusDocumentProcessing.mm:

if (((NSNumber*)templated_) > 0) should now be: if ([((NSNumber*)templated_) integerValue] > 0)

(there are more compiler errors, I am unwrapping them...)

danielweck commented 6 years ago

I applied the recommended XCode changes, and all other failures seem to have been resolved. I will create Pull Requests for the combined fixes for SDKLauncher-iOS, readium-sdk and readium-lcp-client.

danielweck commented 6 years ago

Pull Request: https://github.com/readium/readium-lcp-client/pull/48

danielweck commented 6 years ago

readium-sdk PR: https://github.com/readium/readium-sdk/pull/316

danielweck commented 6 years ago

SDKLauncher-iOS PR: https://github.com/readium/SDKLauncher-iOS/pull/100