readium / readium-sdk

A C++ ePub renderer SDK
BSD 3-Clause "New" or "Revised" License
388 stars 164 forks source link

third-party lib XML for Android, necessary since migration to AndroidStudio / Gradle build config? #244

Closed danielweck closed 8 years ago

danielweck commented 8 years ago

https://github.com/readium/readium-sdk/tree/develop/ePub3/ThirdParty/libxml2-android If not necessary, then let's remove this folder from the source tree.

danielweck commented 8 years ago

I know that libxml2 is technically required for the current build:

https://github.com/readium/readium-sdk/blob/develop/Platform/Android/epub3/Experimental.mk#L81 https://github.com/readium/readium-sdk/blob/develop/Platform/Android/epub3/Stable.mk#L81

https://github.com/readium/readium-sdk/blob/develop/Platform/Android/epub3/build.gradle#L13

I was just wondering whether the NDK updates now allow us to just get rid of this dependency? It seems no:

http://stackoverflow.com/questions/36644473/building-libxml2-into-ndk-with-android-studio-and-gradle-experimental