search

readium / readium-sdk

A C++ ePub renderer SDK
BSD 3-Clause "New" or "Revised" License
388 stars 164 forks source link

feature/content-module branch contains LCP-specific code #256

Closed danielweck closed 8 years ago

danielweck commented 8 years ago

https://github.com/readium/readium-sdk/compare/develop...feature/content-module#diff-50c33a9a94de2830a6e509f112ca8872L37

Proposed solution:

Either: the branch is renamed to feature/lcp to be consistent with the native launcher apps: https://github.com/readium/SDKLauncher-iOS/compare/develop...feature/lcp https://github.com/readium/SDKLauncher-OSX/compare/develop...feature/lcp https://github.com/readium/SDKLauncher-Android/compare/develop...feature/lcp

Or: the branch's code is modified to address only the "content module" requirements (reduced functional scope) .

danielweck commented 8 years ago

Fixed here: https://github.com/readium/readium-sdk/commit/30224571123b585d7aac94d6c0bf9058a25745cf and here: https://github.com/readium/SDKLauncher-iOS/commit/fbb070fe715b86ebab30520aa0d8a02e0210326f