readium / readium-sdk

A C++ ePub renderer SDK
BSD 3-Clause "New" or "Revised" License
383 stars 164 forks source link

IOS-12597: Do not parse smil if creating document failed #313

Open ZakHsieh opened 6 years ago

ZakHsieh commented 6 years ago

Do not continue rest of work if parsing smil(s) failed to avoid the crash later.

danielweck commented 6 years ago

I approve the proposed code change to handle the edge-case of failed XML parsing for SMIL files. @rkwright ? Feel free to merge if you agree.