readium / readium-sdk

A C++ ePub renderer SDK
BSD 3-Clause "New" or "Revised" License
383 stars 164 forks source link

Is this project still actively maintained? #321

Closed HppZ closed 4 years ago

HppZ commented 4 years ago

I want to use this sdk in my windows 10 UWP project.

danielweck commented 4 years ago

Hello, there have been prior efforts to create a Windows-compatible build configuration (Win32, WinRT, and also UWP), but as far as I know this hasn't been maintained for a long time. I cannot remember exactly, but here are related Pull Requests: https://github.com/readium/readium-sdk/pull/192 https://github.com/readium/readium-sdk/pull/124

Personally I have been maintaining the build configurations for Android and iOS, in this PR: https://github.com/readium/readium-sdk/pull/317

HppZ commented 4 years ago

Hi, Why not make it happen, Windows is great and UWP is great. There is no good epub reader on Windows, the legacy Edge was good, but it is not available since Windows 1909, so I want to create a epub app using Xaml, but I need a good epub parser, so I found readium-sdk, could you please please please support Windows platform?

llemeurfr commented 4 years ago

There is no good epub reader on Windows

At EDRLab we're very actively developing Thorium Reader as a "good epub reader on Windows" + MacOS + Linux. We chose Electron to be cross-platform.

could you please please please support Windows platform?

Readium is a community, not a company. The c++ epub parser included in the Readium SDK works well, for several years. Making sure is compiles well and can be UWP wrapped for modern Windows build systems is in your hands. If you decide to do that, a gift to the community would be appreciated.

danielweck commented 4 years ago

Hello again, this is an open-source project, so anybody is welcome to fork the codebase and propose feature extensions / improvements :) That being said, I personally believe the effort required to bridge the C++ code with the UWP framework would be costly, and (in my opinion) not justified. There is more active Readium development in platform-native code (e.g. Android-Kotlin, iOS-Swift), and as Laurent said in his comment above, there is also a cross-platform Electron-based implementation of the same Readium architecture.

HppZ commented 4 years ago

Thanks for all your reply.

I tried Thorium Reader, and an error occured. ![Uploading image.png…]()

HppZ commented 4 years ago

image

HppZ commented 4 years ago

is it trying to connect to internet?

danielweck commented 4 years ago

This bug was fixed after version 1.1.1 was released, could you please try again with a more recent build from: https://github.com/readium/readium-desktop/releases/ Thank you!

HppZ commented 4 years ago

current is v1.1.1

image

danielweck commented 4 years ago

Yes, please try [latest-windows] continuous test build (prerelease)

HppZ commented 4 years ago

oh works fine.

llemeurfr commented 4 years ago

Note that this discussion about Thorium bugs has nothing to do in the readium-sdk area :-)

llemeurfr commented 4 years ago

so, shall we close this issue now?