search

readium / readium-shared-js

Repository for the shared JavaScript libraries that are used in the SDK-Launchers and other applications developed on top of the SDK
BSD 3-Clause "New" or "Revised" License
78 stars 102 forks source link

Reflowable document viewport gets clipped when enlarged (CSS columns) #181

Open danielweck opened 9 years ago

danielweck commented 9 years ago

Originally posted here: http://idpf.org/forum/topic-2430

By http://idpf.org/users/elania Elania (Alex)

" When I have a book open and the new window is fullscreen, a little bit of the left-hand side text is cut off. It's still technically readable, but it makes it much more difficult and is very annoying.

It doesn't do this if I make the screen small enough, but if I have to have it in a separate window, I want to at least have it as large as possible. "

readium error

rkwright commented 9 years ago

This is also reproducible with the current release (0.18 in master) on OSX with SmokeTestFXL.epub

danielweck commented 9 years ago

@rkwright on a fixed-layout (pre-paginated) spine item, or a reflowable document?

rkwright commented 9 years ago

I have been able to reproduce only in fixed layout. Reflowable (in my limited testing) seems fine.

theWhiteFox commented 9 years ago

I have the same issue, my workaround is to change layout to document. Unfortunately doing this only displays a single page, however it least the page is not cropped.

johanpoirier commented 9 years ago

Some people in my company have the same issue but I haven't be able to observe it on my own laptop (MacBook Air).

johanpoirier commented 9 years ago

I located the bug.

The column width is computed with a Math.round():

And when we compute the page offset, we use the rounded value of the column width: https://github.com/readium/readium-shared-js/blob/develop/js/views/reflowable_view.js#L456

I think of 2 solutions:

Any thoughts?

danielweck commented 9 years ago

To those of you following this discussion thread, @johanpoirier kindly looked into this rounding issue, and has run some tests: https://github.com/readium/readium-shared-js/pull/188#issuecomment-110725956

danielweck commented 9 years ago

More screenshots from @thiagoeec here: https://github.com/readium/readium-js-viewer/issues/344

vamsundar commented 9 years ago

Still we are facing this issue, is there any update on this issue...

untitled

jccr commented 9 years ago

Oh I re-opened this one, and wrote comments: https://github.com/readium/readium-shared-js/issues/37

They look like the same issue to me.

danielweck commented 8 years ago

Similar (identical) issue? https://github.com/readium/readium-shared-js/issues/283