search

readium / readium-shared-js

Repository for the shared JavaScript libraries that are used in the SDK-Launchers and other applications developed on top of the SDK
BSD 3-Clause "New" or "Revised" License
78 stars 102 forks source link

Code aggregation, minification, optimisation? #63

Open danielweck opened 10 years ago

danielweck commented 10 years ago

Native launcher apps currently include the Javascript codebase as-is, using direct links to individual files. The readium-js and readium-js-viewer repositories contain build tasks that take care of packaging the JS payload from readium-shared-js. Should a similar build subsystem be provided for the native apps? (note: this would require some changes in the automated Continuous Integration build scripts in Jenkins)

bluefirepatrick commented 10 years ago

Since OSX and iOS (and perhaps more environments) let you debug into the webviews that render the ebooks, it would make sense to keep the individual files from a debugging standpoint. Patrick

On Fri, Jul 25, 2014 at 3:50 PM, danielweck notifications@github.com wrote:

Native launcher apps currently include the Javascript codebase as-is, using direct links to individual files. The readium-js and readium-js-viewer repositories contain build tasks that take care of packaging the JS payload from readium-shared-js. Should a similar build subsystem be provided for the native apps? (note: this would require some changes in the automated Continuous Integration build scripts in Jenkins)

— Reply to this email directly or view it on GitHub https://github.com/readium/readium-shared-js/issues/63.

Patrick Keating CTO, Bluefire Productions Seattle, WA (206) 781-1411

danielweck commented 10 years ago

@bluefirepatrick Right, we have the same "problem" in the cloud reader and the Chrome extension: the JS source code is not minified / obfuscated, but the debugger has to step through a single large file Readium.js

bluefirepatrick commented 10 years ago

The large un-minified file is still quite workable for debugging, like when debugging with readium-js-viewer. I thought that the 'production' minified/uglified js was being suggested for the launchers. If not, I am not opposed to the large file being used if its an advantage.

On Thu, Jul 31, 2014 at 1:58 AM, danielweck notifications@github.com wrote:

@bluefirepatrick https://github.com/bluefirepatrick Right, we have the same "problem" in the cloud reader and the Chrome extension: the JS source code is not minified / obfuscated, but the debugger has to step through a single large file Readium.js

— Reply to this email directly or view it on GitHub https://github.com/readium/readium-shared-js/issues/63#issuecomment-50734304 .

Patrick Keating CTO, Bluefire Productions Seattle, WA (206) 781-1411