search

readium / swift-toolkit

A toolkit for ebooks, audiobooks and comics written in Swift
https://readium.org/mobile/
BSD 3-Clause "New" or "Revised" License
256 stars 101 forks source link

Not able to configure swift toolkit 2.4.0 using carthage #268

Closed AmitSP91 closed 1 year ago

AmitSP91 commented 1 year ago

Bug Report

I am trying to upgrade swift-toolkit version via carthage using :--> github "readium/swift-toolkit" ~> 2.4.0

What happened?

I am trying to upgrade swift-toolkit using carthage:--> github "readium/swift-toolkit" ~> 2.4.0 Initially it started updating carthages and continued processing for couple of hours and later it terminated the process in terminal. At the end updating carthage remains unsuccessful.

Expected behavior

  1. I need to upgrade swift-toolkit to version 2.4.0 using :- github "readium/swift-toolkit" ~> 2.4.0
  2. FYI: Previously we were using followings to install swift toolkit frameworks Question: Will these still work for us to fetch updated frameworks version from develop branch github "readium/r2-shared-swift" "develop" github "readium/r2-streamer-swift" "develop" github "readium/r2-navigator-swift" "develop" github "readium/r2-opds-swift" "develop" github "readium/r2-lcp-swift" "develop"

How to reproduce?

  1. Updated this in cart file :-> github "readium/swift-toolkit" ~> 2.4.0
  2. Followed the steps to update the Carthages via Terminal XCode14.0
  3. It initiated the upgrading carthages.
  4. Continue updating and stuck at random point in between for couple of hours and later it terminates the process.

Environment

AmitSP91 commented 1 year ago

@Team Can you please help me out for this swift-toolkit issue.

mickael-menu commented 1 year ago

Which Carthage command are you using and what logs do you get? You can add the --verbose flag to get more information.

AmitSP91 commented 1 year ago

@mickael-menu Thanks for quick response.

Here's he command I am using to install carthages.

  1. brew cleanup
  2. rm -rf ~/Library/Developer/Xcode/DerivedData
  3. rm -rf ~/Library/Caches/org.carthage.CarthageKit
  4. rm -rf ~/Library/Caches/carthage
  5. rm -rf Carthage
  6. carthage update --use-xcframeworks --platform ios

And below is the SS from terminal as end result.

SS1
mickael-menu commented 1 year ago

And with the --verbose flag added to the carthage command?

AmitSP91 commented 1 year ago

No, It's no added as of now Can you please suggest a way how to add it and where to add it?

mickael-menu commented 1 year ago

Run carthage update --use-xcframeworks --platform ios --verbose.

AmitSP91 commented 1 year ago

@mickael-menu I have tried with this command as well carthage update --use-xcframeworks --platform ios --verbose

But still same output, not such detailed logs there in terminal See attached SS.

SS2
mickael-menu commented 1 year ago

Then I'm not sure what's the problem, it looks like an issue with Carthage on your end. It runs fine for me.

AmitSP91 commented 1 year ago

Hi @mickael-menu I have configured carthages for swift toolkit successfully
Thank for your support.

We have one small query. After updating swift-toolkit to 2.4.0, Does R2Lcp binaries needs to be updated to the latest version?

We are having r2Lcp binaries i.e: "https://liblcp.dita.digital/readium/liblcp/ios/carthage/XXXXXXXX/liblcp.json" ~> 2.0.0 Which is having some older versions like 2.0.0, 2.1.0 etc... Also some of the new binaries we have with 3.0.0 & 3.1.0 versions.

Do we need to update all these binaries to the latest versions?

mickael-menu commented 1 year ago

No the liblcp is a different project than the Readium toolkit and you don't need to update them at the same time.

AmitSP91 commented 1 year ago

@mickael-menu Thank you for your reply. Would like to understand that when do we need to update this liblcp binaries?