search

readium / swift-toolkit

A toolkit for ebooks, audiobooks and comics written in Swift
https://readium.org/mobile/
BSD 3-Clause "New" or "Revised" License
223 stars 96 forks source link

Initial pass at `Locator.Locations.time` #382

Closed domkm closed 5 months ago

domkm commented 5 months ago

Implements #372.

@mickael-menu I went with an enum instead of a struct but I can alter it if you wish. Thanks!

domkm commented 5 months ago

Should I also remove the private extension on Locator?

mickael-menu commented 5 months ago

Ha forgot to ask, could you rebase it to develop instead of main? Thanks.

domkm commented 5 months ago

When adding that doc string, I realized that my names are not aligned with the W3 doc that you sent. They use begin, end, and interval, while I used offset, duration, and range. Should I update my names to align with the W3 doc?

mickael-menu commented 5 months ago

Yes I think that would be best to stick to the standard when possible 👍

domkm commented 5 months ago

👍