readmeio / markdown

ReadMe's flavored Markdown parser and React-based rendering engine.
https://rdmd.readme.io
ISC License
34 stars 9 forks source link

React 18 support? #851

Closed adityapatadia closed 6 months ago

adityapatadia commented 6 months ago

We are not able to add this in Next.js 14. Can you add support for react 18?

rafegoldberg commented 6 months ago

This issue was resolved!

🚀 Changes included in v6.78.0

kellyjosephprice commented 6 months ago

This should support react 18 now!

There is a warning about react-codemirror2 not supporting react 8, but it seems fine to me.

$ npm ls react
npm ERR! code ELSPROBLEMS
npm ERR! invalid: react@18.2.0 /home/kelly/wsp/rdmd-react-18/node_modules/react
rdmd-react-18@0.1.0 /home/kelly/wsp/rdmd-react-18
├─┬ @readme/markdown@6.78.0
│ ├─┬ @readme/syntax-highlighter@13.0.0
│ │ ├─┬ react-codemirror2@7.3.0
│ │ │ └── react@18.2.0 deduped invalid: ">=15.5 <=17.x" from node_modules/@readme/syntax-highlighter/node_modules/react-codemirror2
│ │ └── react@18.2.0 deduped
│ ├─┬ @readme/variable@16.0.0
│ │ └── react@18.2.0 deduped
│ ├─┬ @tippyjs/react@4.2.6
│ │ └── react@18.2.0 deduped
│ └── react@18.2.0 deduped
├─┬ @testing-library/react@13.4.0
│ └── react@18.2.0 deduped
├─┬ react-dom@18.2.0
│ └── react@18.2.0 deduped
├─┬ react-scripts@5.0.1
│ └── react@18.2.0 deduped
└── react@18.2.0