readmeio / markdown

ReadMe's flavored Markdown parser and React-based rendering engine.
https://rdmd.readme.io
ISC License
34 stars 9 forks source link

feat: embeds! #878

Closed jennspencer closed 5 months ago

jennspencer commented 5 months ago
icn Fix RM-9017

🧰 Changes

embeds!!!

🧬 QA & Testing

~still need to make updateSnapshot~

jennspencer commented 5 months ago

@kellyjosephprice i dinked around a lot with types and tests here, which looks like it caused some conflicts 😂 i'll muddle through them but will defer to whatever patterns you're using

kellyjosephprice commented 5 months ago

I think I fixed the syntax highlighter dynamic imports on the beta branch

jennspencer commented 5 months ago

@kellyjosephprice the Code component was/is working already, yeah? these errors are just on the test i edited so there's likely more tweaks it needs. the snapshot not matching is odd tho, wtf?

we can add a couple of todos to fix these guys, it's the last "convert component" ticket and i'd like to get crackin' on the editor-side component(s), whatchoo say?

kellyjosephprice commented 5 months ago

@kellyjosephprice the Code component was/is working already, yeah? these errors are just on the test i edited so there's likely more tweaks it needs. the snapshot not matching is odd tho, wtf?

we can add a couple of todos to fix these guys, it's the last "convert component" ticket and i'd like to get crackin' on the editor-side component(s), whatchoo say?

Yea, it seems like there's something weird happening with the compilation step and the dynamic import?

Skip it!

jennspencer commented 5 months ago

@kellyjosephprice the Code component was/is working already, yeah? these errors are just on the test i edited so there's likely more tweaks it needs. the snapshot not matching is odd tho, wtf? we can add a couple of todos to fix these guys, it's the last "convert component" ticket and i'd like to get crackin' on the editor-side component(s), whatchoo say?

Yea, it seems like there's something weird happening with the compilation step and the dynamic import?

Skip it!

YOLO

rafegoldberg commented 5 months ago

This PR was released!

🚀 Changes included in v6.75.0-beta.34