readmeio / markdown

ReadMe's flavored Markdown parser and React-based rendering engine.
https://rdmd.readme.io
ISC License
33 stars 9 forks source link

fix: updates to html block #906

Closed jennspencer closed 2 months ago

jennspencer commented 2 months ago
PR App Fix RM-10043

🧰 Changes

Reworks HTML blocks a bit so they're nicer and easier for the user to interact with (makes sure the HTML is always nicely formatted for slate and the markdown/mdx doc)

🧬 QA & Testing

jennspencer commented 2 months ago

@kellyjosephprice i stg greg made a comment somewhere that he preferred the scenario i was trying to munge, but i can't find anywhere it so it's possible i'm losing my mind.

if the user does decide to indent the html in the HTMLBlock, it'll show up in the widget's code editor with the indents though. is that enough of an issue to do something about or just leave it? i'm wildly ambivalent, mostly because users probably tend to stick with their preferred way of editing (editor vs raw markdown)

oh and i'm totally fixing the test, just had to figure out what was the "correct" outcome of it first 😂

rafegoldberg commented 2 months ago

This PR was released!

🚀 Changes included in v6.75.0-beta.60