style(demo): set root font-family

readmeio / markdown

ReadMe's flavored Markdown parser and React-based rendering engine.

https://rdmd.readme.io

ISC License

33 stars 9 forks source link

style(demo): set root font-family #909

Open rafegoldberg opened 2 months ago

rafegoldberg commented 2 months ago

🧰 Changes

[x] set the root font-family to the system font
[x] update visual test snapshots

🧬 QA & Testing

Check out this branch and run start. If you don't see Times New Roman, this worked! :tada:

rafegoldberg commented 2 months ago

Urg, will update the visual tests before I merge.

rafegoldberg commented 2 months ago

Okay, well I tried to update ‘em with -u and it worked locally, but apparently they still don't match on CI! My guess is it's because they're using a different system font? Not sure how to get ‘em to update/match in this scenario; do you have any ideas @kellyjosephprice? Maybe this is why we haven't fixed this issue?

jennspencer commented 2 months ago

@rafegoldberg you'll need to fire up docker and use make updateSnapshot

rafegoldberg commented 2 months ago

Nice, that worked—thanks @jennspencer.