readmeio / markdown

ReadMe's flavored Markdown parser and React-based rendering engine.
https://rdmd.readme.io
ISC License
33 stars 9 forks source link

fix: compatibility for unknown nodes #929

Closed jennspencer closed 2 months ago

jennspencer commented 2 months ago
PR App Fix RM-10063

🧰 Changes

Unhandled nodes are throwing errors during migration. Offending node types:

🧬 QA & Testing

You can look up the Cannot handle unknown node <node> errors from Aaron's migration spreadsheet to find pages to test locally, if you want to use make mdx to swap out the dist files in your readme repo.

You'll have to check out his other PR with the migration scripts first, which has directions for testing pages.

jennspencer commented 2 months ago

this will cause some of the pages with div node errors to instead error with Expected component 'TutorialTile' to be defined: you likely forgot to import, pass, or provide it.

i'm assuming that's because custom components aren't being sent in the migration script--easy enough to fix

kellyjosephprice commented 2 months ago

this will cause some of the pages with div node errors to instead error with Expected component 'TutorialTile' to be defined: you likely forgot to import, pass, or provide it.

i'm assuming that's because custom components aren't being sent in the migration script--easy enough to fix

Yea, it's defined in the main app. We should probably add a stub to the migration so we don't got those errors.

rafegoldberg commented 2 months ago

This PR was released!

🚀 Changes included in v6.75.0-beta.70