readmeio / metrics-sdks

SDKs and integrations for ReadMe's Metrics platform
https://readme.com/metrics
9 stars 22 forks source link

fix(node): avoid rethrowing errors when development=true #1003

Open mothershipper opened 1 month ago

mothershipper commented 1 month ago

When development=true, the SDK re-throws in a floating promise, leaving no way for the caller to catch it. This crashes the node process.

In lieu of proposing an error handling or logging API to use, this PR/commit is more to point out the problem than suggest a long-term solve.

See #1001 for context