search

readmeio / metrics-sdks

SDKs and integrations for ReadMe's Metrics platform
https://readme.com/metrics
9 stars 22 forks source link

fix: PHP SDK requires composer itself #987

Open xolf opened 2 months ago

xolf commented 2 months ago

The readme/metrics requires Composer itself. As mentioned by the maintainers of Composer, see https://github.com/composer/composer/issues/11940#issuecomment-2068728878, this is a bad design and lead to unusable composer installation if the version within the vendor folder differs from the system-wide installation.

I'm not quite sure, what are the reasons to require composer/composer itself, but not other package are requiring composer, so one should be safe to remove.

Seldaek commented 2 months ago

I guess it might have been a misunderstanding that this is needed for InstalledVersions to work. But that's just always available when the composer-runtime-api requirement is fullfilled so it should be fine. Removing the require on composer/composer definitely would be good.