search

readrops / Readrops

Android multi-services RSS client
GNU General Public License v3.0
272 stars 20 forks source link

remoteId is the only criterion in deleteByIds #100

Closed shunf4 closed 3 years ago

shunf4 commented 3 years ago

https://github.com/readrops/Readrops/blob/52fda0f8d8be57b4515b3f78b34ed9bbcc047886/db/src/main/java/com/readrops/db/dao/FeedDao.java#L130

https://github.com/readrops/Readrops/blob/52fda0f8d8be57b4515b3f78b34ed9bbcc047886/db/src/main/java/com/readrops/db/dao/FeedDao.java#L84-L85

Isn't is possible that two feeds in two different FreshRSS instances share the same remoteId? It's dangerous we use remoteId as the only condition to do deletion.

Shinokuni commented 3 years ago

Thank you for pointing this out, indeed this could delete ids from multiple accounts.