[Bug] Error parsing yarr fever API feeds response

[fenuks]

Describe the bug yarr is a server with fever API support. Its fever implementation seems to be correct, and it works with NewsFlash and Read You.

Trying to fetch/refresh feeds yields JsonDataException with message Expected BEGIN_ARRAY but was NUMBER at path $.last_refreshed_on_time. As I understand, assumption that the first three fields of the feeds response are api_version, auth, last_refreshed made here is incorrect. In general, assuming any order doesn't seem like a good idea. In case of yarr, field order is different:

{
    "api_version": 3,
    "auth": 1,
    "feeds": [],
    "feeds_groups": [],
    "last_refreshed_on_time": 1731858050
}

To Reproduce Steps to reproduce the behaviour:

1. Add yarr account (default URL is http://my_ip:7070/fever/), by default auth is not enabled, so any login/password combination will work
2. Tap refresh feeds button
3. See error

Environment information (please complete the following information):

• Account type: Fever
• App version: 2.0.1 (also tested app built from the latest git version, namely db04cdd)
• Stacktrace collected from logcat

  Caused by: com.readrops.api.utils.exceptions.ParseException: Expected BEGIN_ARRAY but was NUMBER at path $.last_refreshed_on_time
  at com.readrops.api.services.fever.adapters.FeverFeedsAdapter.fromJson(FeverFeedsAdapter.kt:94)
  at com.readrops.api.services.fever.adapters.FeverFeedsAdapter.fromJson(FeverFeedsAdapter.kt:19)
  at retrofit2.converter.moshi.MoshiResponseBodyConverter.convert(MoshiResponseBodyConverter.java:46)
  at retrofit2.converter.moshi.MoshiResponseBodyConverter.convert(MoshiResponseBodyConverter.java:27)
  at retrofit2.OkHttpCall.parseResponse(OkHttpCall.java:246)
  at retrofit2.OkHttpCall$1.onResponse(OkHttpCall.java:156)
  at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519)
  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
  at java.lang.Thread.run(Thread.java:920)

[Shinokuni]

Indeed, you're right, I fixed this behavior in FeverItemsAdapter, but not in FeverFeedsAdapter, thanks for reporting! A fix will be available in the next version.

[Shinokuni]

Fixed in d2dff633e1a2d68b6882b83762db9beff550d336.

[fenuks]

Thank you for the quick fix!

Are you certain that this will work for any order of fields? I don't know how exactly Reader works, but it seems to me that now parser expects that feeds field goes first, then feed_groups – so order still matters, just differently. When I moved feed_groups before feeds in api/src/test/resources/services/fever/feeds.json, parsing test failed.