readrops / Readrops

Android multi-services RSS client
GNU General Public License v3.0
272 stars 20 forks source link

Breaking change in News 15.1.0 #87

Closed Grotax closed 3 years ago

Grotax commented 3 years ago

Brief description of the issue.

With news 15.1.0 we have a change in the feed attribute "folderId", if the feed is in the root folder the id will be "null" instead of 0.

See https://github.com/nextcloud/news/issues/939

How to reproduce the bug?

  1. Install 15.1.0-rc2
  2. sync
  3. ...

What was the expected result?

Accept both 0 and null as a value at least for a while to allow for a smooth transition.

Shinokuni commented 3 years ago

Thanks for telling me. What about /feeds/{feedId}/move which has a folderId attribute when you want to move a feed to the root?

Grotax commented 3 years ago

It should also be null, might not work at the moment we are still testing.

anoymouserver commented 3 years ago

I've tested all occurences where the root folder is a valid input. They currently work with both null and 0 https://github.com/nextcloud/news/issues/939#issuecomment-725904099

Shinokuni commented 3 years ago

It is stated in the documentation for call /feeds/{feedId}/move to use a null value like this: "folderId" : null, yet it gives me an 500 error. It only works like this: "folderId : "null". Is this a wanted behavior?

Grotax commented 3 years ago

@Shinokuni which version of news are you using?

I just tested it with 15.1.0-rc3 in insomnia and null worked fine

Shinokuni commented 3 years ago

Sorry, I should have added it. I'm using 14.2.2. So I should wait for at least 15.1.0 before using null for this call.

Grotax commented 3 years ago

Yea we are basically waiting for clients to update or at least give the maintainers a chance before we push 15.1.0 as an update to all users.

But there will always be someone with a incomparable version combination.

Shinokuni commented 3 years ago

I have just created a new release with the fix. I will keep an eye on news version for /feeds/{feedId}/move call.