readsoftware / ReadIssues

This is an issue repository for READ. Intended for issues and feature change request that arise during testing and development.
0 stars 0 forks source link

Glossary RTF - alternate link #141

Open IanMcCrabb opened 5 years ago

IanMcCrabb commented 5 years ago

Alternate link is not being displayed in Glossary RTF. Should be displaying as per see link.

Cant locate the original issue, but I thought this had been working.

stevewh commented 5 years ago

This is a term table issue where term 1434,1435,1439 and 1440 (CompoundConstituent, CompoundConstituentHead, Compare and See) originally had trm_parent_id of 278 (LinkageType) and the code was changed to have 1444 (LemmaLinkage) which has a parent of 278 I have run queries below to fix bc02gbt on LMU server.

The following query will show the issue select trm_id, trm_labels, trm_parent_id from term where trm_id in (1434, 1435, 1439, 1440);

if parent id is 278 then determine we need to determine the source of the terms and ensure that its is updated for a single db that you intend to run on V1RC you can let me know and I will update it or you can run update term set trm_parent_id = 1444 where trm_id in (1434, 1435, 1439, 1440);

This meant that creating links would create the annotation correctly but with an empty type.

for lem:nnn links the type id should be 1434,1435,1439, 1440 or 1445 running the following queries will identify the problem

If you have been working on compound analysis in a glossary then contact me with your db or should run the follow query to check select ano_id , ano_linkfrom_ids, ano_linkto_ids, ano_type_id from annotation where ano_linkto_ids is not null; if the type id is empty then we will need to identify the work your are doing to determine the link type

andrea103 commented 5 years ago

tested OK on bc02GBT (V1RC). (Not sure if I can close this issue. There's nothing more from my side.)

IanMcCrabb commented 5 years ago

I'll need some time to work through this so best to leave it open for the moment.

IanMcCrabb commented 5 years ago

Checked the db in question and can confirm that the problem is not related to the parent term. Terms are all correct

1434 | en=>"CompoundConstituent" | 1444 1435 | en=>"CompoundConstituentHead" | 1444 1439 | en=>"Compare" | 1444 1440 | en=>"See" | 1444 1445 | en=>"Alternate" | 1444

Have an Alternate link between Lem that is not being displayed in the glossary RTF.

stevewh commented 5 years ago

Are the ownership and visibility correct?

On Mon, Dec 2, 2019 at 6:25 AM IanMcCrabb notifications@github.com wrote:

Checked the db in question and can confirm that the problem is not related to the parent term. Terms are all correct

1434 | en=>"CompoundConstituent" | 1444 1435 | en=>"CompoundConstituentHead" | 1444 1439 | en=>"Compare" | 1444 1440 | en=>"See" | 1444 1445 | en=>"Alternate" | 1444

Have an Alternate link between Lem that is not being displayed in the glossary RTF.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/readsoftware/ReadIssues/issues/141?email_source=notifications&email_token=AARYOIKUK5KGT24UEY2ATULQWSL4LA5CNFSM4G5HNR6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFSISUI#issuecomment-560236881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARYOIOSE65Z6WSBO2YCCFLQWSL4LANCNFSM4G5HNR6A .

stevewh commented 5 years ago

What is the usage rules for Compare, See and Alternative for links/relations between Lemma?

On Mon, Dec 2, 2019 at 6:53 AM Stephen White stephenawhite57@gmail.com wrote:

Are the ownership and visibility correct?

On Mon, Dec 2, 2019 at 6:25 AM IanMcCrabb notifications@github.com wrote:

Checked the db in question and can confirm that the problem is not related to the parent term. Terms are all correct

1434 | en=>"CompoundConstituent" | 1444 1435 | en=>"CompoundConstituentHead" | 1444 1439 | en=>"Compare" | 1444 1440 | en=>"See" | 1444 1445 | en=>"Alternate" | 1444

Have an Alternate link between Lem that is not being displayed in the glossary RTF.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/readsoftware/ReadIssues/issues/141?email_source=notifications&email_token=AARYOIKUK5KGT24UEY2ATULQWSL4LA5CNFSM4G5HNR6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFSISUI#issuecomment-560236881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARYOIOSE65Z6WSBO2YCCFLQWSL4LANCNFSM4G5HNR6A .

stevewh commented 5 years ago

Pushed a fix for this.

On Tue, Dec 3, 2019 at 2:32 PM Stephen White stephenawhite57@gmail.com wrote:

What is the usage rules for Compare, See and Alternative for links/relations between Lemma?

On Mon, Dec 2, 2019 at 6:53 AM Stephen White stephenawhite57@gmail.com wrote:

Are the ownership and visibility correct?

On Mon, Dec 2, 2019 at 6:25 AM IanMcCrabb notifications@github.com wrote:

Checked the db in question and can confirm that the problem is not related to the parent term. Terms are all correct

1434 | en=>"CompoundConstituent" | 1444 1435 | en=>"CompoundConstituentHead" | 1444 1439 | en=>"Compare" | 1444 1440 | en=>"See" | 1444 1445 | en=>"Alternate" | 1444

Have an Alternate link between Lem that is not being displayed in the glossary RTF.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/readsoftware/ReadIssues/issues/141?email_source=notifications&email_token=AARYOIKUK5KGT24UEY2ATULQWSL4LA5CNFSM4G5HNR6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFSISUI#issuecomment-560236881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARYOIOSE65Z6WSBO2YCCFLQWSL4LANCNFSM4G5HNR6A .