readthedocs / actions

GitHub Actions for Read the Docs
MIT License
33 stars 10 forks source link

Use actions/toolkit #30

Open LecrisUT opened 1 year ago

LecrisUT commented 1 year ago

The github actions documentation encourages using actions/toolkit

Ok, this one became more complicated than initially thought. Changing from a composite action to a js action requires a compilation step of a dist/index.js file. Not sure if it's worth having the additional steps.


:books: Documentation preview :books:: https://readthedocs-preview--30.org.readthedocs.build/en/30/

humitos commented 1 year ago

Hi! I'm a little new on the GitHub Actions world. Can you please explain to me what are the benefits of actions/toolkit over the current pattern we are following here?

LecrisUT commented 1 year ago

Initially I thought it can make it cleaner and more in line with upstream documentation, but having to enforce a compilation workflow is a bit of a disadvantage. Maybe if we push compilation commits automatically, it wouldn't be that bad.

Other than that there can be some benefits: