search

readthedocs / addons

JavaScript client to integrate with Read the Docs nicely
https://readthedocs-addons.readthedocs.io/
MIT License
21 stars 6 forks source link

Duplication of fly-out and banners #412

Open bjlittle opened 2 weeks ago

bjlittle commented 2 weeks ago

Thanks for the new RTD addons, they're pretty awesome 💯

However, I have noticed now that the new addons are default, the fly-out is being replicated within an interactive tab in our geovista project (docs)

e.g., see this FVCOM Bathymetry interactive gallery example shown below (ensure to click the Interactive Scene tab) and notice the duplicated fly-out within the window. Note that, all addons are duplicated e.g., version banners at al

image

Is there something that you can fix on your side to prevent this happening?

This wasn't an issue previously.

Many thanks :beers:

humitos commented 2 weeks ago

Thanks for reporting this issue.

It took a quick look and I found that page performs a behind the scenes request to https://geovista.readthedocs.io/en/latest/_static/static_viewer.html with ?fileURL=../_images/generated/gallery/warp/images/sphx_glr_from_unstructured__fvcom_001.vtksz as argument

The final URL is https://geovista.readthedocs.io/en/latest/_static/static_viewer.html?fileURL=../_images/generated/gallery/warp/images/sphx_glr_from_unstructured__fvcom_001.vtksz

Since that URL is an HTML file, our CF worker is executed on that page and all the addons are added there as well. I don't have an answer to your question right now, but we will debugging/thinking a little more about this.