search

readthedocs / ads-for-opensource

An Adblock/AdblockPlus/uBlock compatible filter list for allowing advertising that benefits open source
https://ads-for-open-source.readthedocs.io
MIT License
22 stars 10 forks source link

Add rules for Richie Bendall's Website #9

Closed Richienb closed 5 years ago

davidfischer commented 5 years ago

The rules in this PR are too generic and would potentially unblock Carbon/BuySellAds or Doubleclick across all sites. Your rules need to specifically reference the site where those should be unblocked (eg. https://www.richie-bendall.ml/).

Richienb commented 5 years ago

@davidfischer So, my domain is richie-bendall.ml. How do I change the rules so it only applies to it? The ADP cheatsheet hasn't been of much use to me.

davidfischer commented 5 years ago

Something like this should work well at least for Carbon. I didn't see any Google ads on your domain:

@@||carbonads.com^$domain=richie-bendall.ml
@@||carbonads.net^$domain=richie-bendall.ml
@@||buysellads.net^$domain=richie-bendall.ml

The ADP cheatsheet hasn't been of much use to me.

The syntax here could be better documented for sure.

Richienb commented 5 years ago

@davidfischer Thanks! I'm going to fix the rules now.

Richienb commented 5 years ago

@davidfischer Done! Just for clarification, doubleclick.net is used by Carbon to count the number of times the ad loaded.

davidfischer commented 5 years ago

Just for clarification, doubleclick.net is used by Carbon to count the number of times the ad loaded.

Ahhh true. I have seen that but only on Google ads served by Carbon. However, I'm sure that other advertisers on Carbon use that with Google Doubleclick Manager.

This looks good!

Richienb commented 5 years ago

Thanks!